Conversation
Collaborator
|
Hey @merydian you leaked your API key in this branch. Best remove it from the commit, force push to the branch, delete the key from your account and create a new one :) |
Member
|
Incredible work @merydian ! Only comment from my side, it would be cool if the preview feature can work on an existing list of points when toggled.
|
merydian
force-pushed
the
drag-drop-II
branch
from
4d2d2aa to
4dbf6dd
Compare
Collaborator
|
Hey,
|
Collaborator
|
Two more comments:
|
koebi
requested changes
Nov 22, 2024
Collaborator
koebi
left a comment
koebi
left a comment
There was a problem hiding this comment.
Two more general comments:
- on profile change, the preview should be re-generated
- tests are missing.
As for the translation:
As usually, you can provide the tr()-functions, I will provide the translation.
ORStools/gui/ORStoolsDialog.py
Outdated
Comment on lines
894
to
898
| "Please use a different point", | ||
| """Could not find routable point within a radius of 350.0 meters of specified coordinate. | ||
| Use a different point closer to a road.""", level=Qgis.MessageLevel.Warning, duration=3) | ||
| Use a different point closer to a road.""", | ||
| level=Qgis.MessageLevel.Warning, | ||
| duration=3, |
ORStoolsDialogUI.py
Outdated
Collaborator
There was a problem hiding this comment.
See comment on ORStools/ORStoolsDialogUI.py.
ORStools/gui/ORStoolsDialog.py
Outdated
Comment on lines
916
to
918
| "Please use a different point", | ||
| """Could not find routable point within a radius of 350.0 meters of specified coordinate. | ||
| Use a different point closer to a road.""", |
Collaborator
|
Moreover, we should look at getting this combined with the ESC/Right-Click feat merged yesterday. |
Collaborator
|
koebi
requested changes
May 9, 2025
we had 10 for testing, was too small, chose 25 as it felt better
koebi
requested changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes all new changes, makes #222 obsolete, closes #204 and is related to #206.