Add a featureId to each annotation feature#704
Closed
garrettjstevens wants to merge 7 commits intomainfrom
Closed
Conversation
Contributor
Author
|
Also still need to add ability to query backend by featureId |
garrettjstevens
force-pushed
the
feature_ids
branch
from
4de5ef7 to
25b032a
Compare
Contributor
Author
|
This was an interesting idea, but just ended up changing too many things for not enough benefit. Maybe we can revisit later if we have a better use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDs are often an important aspect of features, and there have been several requests for being able to manage the IDs. Currently Apollo doesn't treat a GFF3 feature ID attribute any differently from other attributes.
This PR introduces a change so that
featureIdis a top-level attribute of allAnnotationFeatures. That way it can be guaranteed to be singular (attribute values like the default ID one are technically arrays) and can be more easily tracked and edited. On export, thisfeatureIdis placed in the GFF3 ID attribute.Draft for now as I still need to figure out the best way to leverage this change when doing things that potentially create/destroy IDs, like merging or splitting exons or transcripts.