Skip to content

Fix: flip intron strand arrows when view is reversed #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garrettjstevens merged 1 commit into from
Oct 21, 2025
Merged

Fix: flip intron strand arrows when view is reversed #717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/jbrowse-plugin-apollo/src/LinearApolloDisplay/glyphs/GeneGlyph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,19 +434,21 @@ function drawLine(
ctx.strokeStyle = theme.palette.text.primary
const { strand = 1 } = transcript
ctx.beginPath()
// If view is reversed, draw forward as reverse and vice versa
const effectiveStrand = strand * (reversed ? -1 : 1)
// Draw the transcript line, and extend it out a bit on the 3` end
const lineStart = startPx - (strand === -1 ? 5 : 0)
const lineEnd = startPx + widthPx + (strand === -1 ? 0 : 5)
const lineStart = startPx - (effectiveStrand === -1 ? 5 : 0)
const lineEnd = startPx + widthPx + (effectiveStrand === -1 ? 0 : 5)
ctx.moveTo(lineStart, height)
ctx.lineTo(lineEnd, height)
// Now to draw arrows every 20 pixels along the line
// Make the arrow range a bit shorter to avoid an arrow hanging off the 5` end
const arrowsStart = lineStart + (strand === -1 ? 0 : 3)
const arrowsEnd = lineEnd - (strand === -1 ? 3 : 0)
const arrowsStart = lineStart + (effectiveStrand === -1 ? 0 : 3)
const arrowsEnd = lineEnd - (effectiveStrand === -1 ? 3 : 0)
// Offset determines if the arrows face left or right
const offset = strand === -1 ? 3 : -3
const offset = effectiveStrand === -1 ? 3 : -3
const arrowRange =
strand === -1
effectiveStrand === -1
? range(arrowsStart, arrowsEnd, 20)
: range(arrowsEnd, arrowsStart, 20)
for (const arrowLocation of arrowRange) {
Expand Down