Skip to content

Fix: select feature when we create new feature from JBrowse track #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garrettjstevens merged 1 commit into from
Oct 23, 2025
Merged

Fix: select feature when we create new feature from JBrowse track #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/jbrowse-plugin-apollo/src/components/CreateApolloAnnotation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ export function CreateApolloAnnotation({
})
}

await submitChange(change)
await submitChange(change, annotationFeature._id)
}

const copyTranscriptsToDestinationGene = async (
Expand All @@ -397,7 +397,8 @@ export function CreateApolloAnnotation({
assembly: assembly.name,
addedFeature: transcript,
})
await submitChange(change)
// selects the last added transcript
await submitChange(change, transcriptId)
}
}

Expand Down Expand Up @@ -425,8 +426,7 @@ export function CreateApolloAnnotation({
},
},
})
await submitChange(change)
apolloSessionModel.apolloSetSelectedFeature(newGeneId)
await submitChange(change, newGeneId)
}

const extendSelectedDestinationFeatureLocation = async (
Expand Down Expand Up @@ -468,8 +468,14 @@ export function CreateApolloAnnotation({

const submitChange = async (
change: AddFeatureChange | LocationStartChange | LocationEndChange,
selectedFeatureId?: string,
) => {
await apolloSessionModel.apolloDataStore.changeManager.submit(change)
await apolloSessionModel.apolloDataStore.changeManager
.submit(change)
.then(() => {
// Selects the newly added/modified feature
apolloSessionModel.apolloSetSelectedFeature(selectedFeatureId)
})
}

const handleCreateNewGeneChange = (
Expand Down