Fix collaboration server running out of memory on GFF3 import#719
Merged
garrettjstevens merged 1 commit intomainfrom Oct 23, 2025
Merged
Fix collaboration server running out of memory on GFF3 import#719garrettjstevens merged 1 commit intomainfrom
garrettjstevens merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was doing some benchmarking and managed to crash the collaboration server with an out-of-memory error. I realized it was because I imported a GFF3 without sync marks, and the default parser introduced in #681 has
bufferSizebeInfinity, so it tries to hold the whole GFF3 in memory if there are no sync marks. This PR puts in a reasonablebufferSizeof 10,000, similar to what the previous parser had, to avoid this. This means that GFF3s with related features that are very far apart could fail to import properly, but that could probably be solved by sorting the GFF3.