Avoid sub-pixel rendering in sequence display#739
Merged
garrettjstevens merged 1 commit intomainfrom Nov 25, 2025
Merged
Conversation
cmdcolin
pushed a commit
to cmdcolin/Apollo3
that referenced
this pull request
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure all canvas drawing commands in the LinearApolloReferenceSequenceDisplay use integers instead of floating-point numbers. This can help performance (see this tip on MDN), but the motivation was to get rid of some odd artifacts in the rendering. See for example the whitespace between bases of the same color and the irregularity in the border between the base sequence and translation rows in the "before" below.
Before:

After:
