Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While benchmarking feature imports, I noticed that checks seemed to be taking longer than expected. I did a performance profile and found some things that helped quite a bit. Checking 1000 features goes from about 2m30s to about 35s with these changes. Most of them have to do with allowing the checks to get the sequence for various ranges more efficiently.
structuredCloneI still need figure out an optimization for getting a lot of small sequences. The check that makes sure the splice sites are canonical needs to get a lot of 3bp sequences, and these calls seem to take a lot of time. If I remove that part of the check altogether, it drops the time for checking 1000 features to about 12s.