Conversation
Contributor
Author
|
More technical details: We have a number of 'business needs' including
|
Contributor
Author
|
reverted because of odd build errors in vite embedded "document.head not defined" |
Contributor
Author
|
actually managed to make work in v2.0.6 |
Contributor
Author
|
there are various challenges with embedded usage, where it complains about use of fs/promises because the LocalFile exclude doesn't work. could revert if it is really troublesome... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 5d920d2 we had to revert the ESM-ness of the build back to CJS. This restores it
Larger context
Other ESM modules have trouble importing CJS modules which this module, as noted above, was converted to. This continues on as an ESM