Add browser-specific bundle that excludes localFile#9
Merged
Conversation
Contributor
Author
|
tested and works in next.js, jbrowse-components with mock, and also works with jbrowse-desktop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is yet another PR in attempting better ESM support. I am hoping to bring it to a close
This PR adds a browser specific build that excludes the LocalFile class
This actually requires jbrowse-components to mock the LocalFile, because it uses the browser-specific bundle in jest, but also uses LocalFile in jest as part of various "fetch mocks"