Skip to content

Allow 'hydrating' a defaultSession that does not specify the display type of a track #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cmdcolin wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Allow 'hydrating' a defaultSession that does not specify the display type of a track #4444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99e06fb
Revert "Remove --tracks and --view options from set-default-session C…
cmdcolin Jun 14, 2024
665f843
Automatically add a display if none is specified
cmdcolin Jun 14, 2024
72a38da
[skip ci] Merge origin/main
cmdcolin Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/core/pluggableElementTypes/models/BaseTrackModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { lazy } from 'react'

import { types } from '@jbrowse/mobx-state-tree'
import { addDisposer, types } from '@jbrowse/mobx-state-tree'
import Save from '@mui/icons-material/Save'

import { ConfigurationReference, getConf } from '../../configuration'
Expand All @@ -19,6 +19,7 @@ import type {
} from '../../configuration'
import type { MenuItem } from '../../ui'
import type { IAnyStateTreeNode, Instance } from '@jbrowse/mobx-state-tree'
import { autorun } from 'mobx'

const SaveTrackDataDlg = lazy(() => import('./components/SaveTrackData'))

Expand Down Expand Up @@ -304,6 +305,20 @@ export function createBaseTrackModel(
: []),
]
},
afterAttach() {
addDisposer(
self,
autorun(() => {
if (!self.displays.length) {
const compatDisp = getCompatibleDisplays(self)
console.log({ compatDisp })
self.showDisplay(
self.configuration.trackId + '-' + compatDisp[0].type,
)
}
}),
)
},
}))
.postProcessSnapshot(snap => {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
Expand Down
Loading