Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experimental PR that is somewhat of a large refactor aiming to fix issues like #3965
The use of mixins allows shared functionality but it also has caused confusion with
a) typescript types in some cases
b) just a general confusion of not really being sure where functionality lives
Making this change would cause more code duplication, but I think it may improve developer experience and some usage of typescript typings (it is not 100% ideal typescript wise because each "product" has it's own session types and "plugins" operate on a duck-typed version of the session model generally, not the true type of the each products session model)