Open
Conversation
yueguobin
added a commit
to yueguobin/gns3-web-ui
that referenced
this pull request
Mar 26, 2026
…icons (GNS3#1534) Enable PNG screenshot export on all platforms (Linux/macOS/Windows) and fix missing icons when exporting custom symbols cached as blob URLs. Changes: - Remove Windows-only restriction for PNG export (isPngAvailable = true) - Remove DeviceDetectorService dependency (no longer needed) - Fix blob URL icons not appearing in PNG exports: * Detect blob URLs vs server symbol URLs * Fetch blob content directly from browser cache * Use importNode to properly inline SVG with viewBox - Improve PNG export robustness: * Use cloneNode() to avoid modifying original SVG * Add try-catch error handling with user feedback * Process embedded images with better error recovery - Add ToasterService for error notifications Resolves GNS3#1534 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
commit 9b0b1af 2026-03-27_01-50-46.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.