for Qstrings and QByteArrays prefer isEmpty() over size() and length()

[tsteven4]

This applies the clang-tidy readability-container-size-empty check to QString and QByteArrays.

This check normally doesn't work because unlike QList QString and QByteArray don't have an empty() method. By editing qstring.h and qbytearray.h an empty() method can be added. When running clang-tidy use the export-fixes option as the fixes will use empty() instead of isEmpty(). Edit the fixes file changing the replacment text to use isEmpty() instead of empty(): 'g/ReplacementText/s/\.empty()/.isEmpty()/g' and 'g/ReplacementText/s/->empty()/->isEmpty()/g', and then run clang-apply-replacements.

You may note some replacements where the original code didn't use size() or length(), but instead used equality comparisons to "" or QString(). These were generated by the readability-container-size-empty check, and should work fine. I did compare the optionList generated by formatload and found it equivalent.

[robertlipe]

Nice! Some day, we should get that going on patches coming in so we don't introduce regressions.

…

On Thu, Feb 13, 2025 at 2:44 PM tsteven4 ***@***.***> wrote: Merged #1409 <#1409> into master. — Reply to this email directly, view it on GitHub <#1409 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCSD3ZQHDD2FZOCKCSMPGD2PT7Z7AVCNFSM6AAAAABXCQ6HT6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGMYDENBZG4ZDGMA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>