add cmake option: upgrade chk and stats reporting.#1413
Merged
tsteven4 merged 7 commits intoGPSBabel:masterfrom Sep 14, 2025
Merged
add cmake option: upgrade chk and stats reporting.#1413tsteven4 merged 7 commits intoGPSBabel:masterfrom
tsteven4 merged 7 commits intoGPSBabel:masterfrom
Conversation
Collaborator
Author
|
One point of view is that users of apps distributed by packagers should check for the existence of an upgrade by the methods used by that system, e.g. apt-get, dnf, ... These report if an updated package is available independent of an upstream release. |
Collaborator
Author
|
@jspricke can you comment on the desirability of this? I believe it could replace some of your patches. I don't see a need for you to incorporate it until something else drives a change. |
Contributor
|
This would be great, thanks for proposing it. |
vincele
reviewed
Sep 13, 2025
vincele
left a comment
vincele
left a comment
There was a problem hiding this comment.
This looks very useful, and the modifications sensible enough for my (untrained) eyes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many linux distributions prefer not to have the upgrade check and statistics reporting.
Add a cmake options to disable them. This removes gui/upgrade.* from the build and the related items from the menus. By default the upgrade check and statistics reporting are ON as they have traditionally been.
cmake -DGPSBABEL_UPGRADE_CHECK=OFF ...