Reflect upstream const changes #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsymalla
force-pushed
the
recordkeeper_const
branch
from
4990dd2 to
0d1b1e1
Compare
tsymalla-AMD
changed the title
Record * members const`TableGenFnMain` was changed to pass a `const RecordKeeper &`, so reflect that change in `llvm-dialects`. Also, `const Record *` pointers are handed out now. Guard both versions with LLVM_MAIN_REVISION to ensure upstream and downstream CI continues to work.
tsymalla
force-pushed
the
recordkeeper_const
branch
from
0d1b1e1 to
d0da7de
Compare
dstutt
approved these changes
Oct 4, 2024
|
Note we already have a dependency on |
Yes, this single dependency can be removed now, I will take care of that later. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableGenFnMainwas changed to pass aconst RecordKeeper &, soreflect that change in
llvm-dialects. Also,const Record *pointersare handed out now.
Adds a bunch of changes to make
Record *const overall.Guard both versions with LLVM_MAIN_REVISION to ensure upstream and
downstream CI continues to work.