Skip to content

Conversation

@tsymalla
Copy link
Contributor

@tsymalla tsymalla commented Nov 22, 2024

Add an enum that helps identifying specific argument slots by providing access to the indices used in getArgOperand.

Note: I plan to make use of this in a follow-up PR during generation of the dialect op definition C++ code.

Add an enum that helps identifying specific argument slots by providing
access to the indices used in `getArgOperand`.
Copy link
Contributor

@jasilvanus jasilvanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

Maybe we should also add a TailStart or VarArgsStart value?

Copy link
Contributor

@jasilvanus jasilvanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

I'll leave approval to @Flakebi or @nhaehnle.

Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

@tsymalla-AMD tsymalla-AMD merged commit b7ee542 into GPUOpen-Drivers:dev Dec 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants