Auto-generate comments for dialect ops. #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the summary and description fields for dialect ops remain unused. Add those as comment above the class declaration.
tsymalla-AMD
requested review from
Flakebi and
nhaehnle
and removed request for
Flakebi
Flakebi
reviewed
Feb 18, 2025
tsymalla-AMD
approved these changes
Feb 18, 2025
|
Ugh... we shouldn't allow defining ops without summary or description :( |
I can validate that as follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the summary and description fields for dialect ops remain unused. Add those as comment above the class declaration.