Skip to content

EmitLongStrLiterals cl::opt is now global in upstream LLVM #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

EmitLongStrLiterals cl::opt is now global in upstream LLVM #123

merged 1 commit into from
Apr 15, 2025

Conversation

@mariusz-sikora-at-amd
Copy link
Contributor

LLVM upstream change: llvm/llvm-project#124856 makes EmitLongStrLiterals cl::opt global

@mariusz-sikora-at-amd
EmitLongStrLiterals cl::opt is now global in upstream LLVM
641f001 
LLVM upstream change: llvm/llvm-project#124856
makes EmitLongStrLiterals cl::opt global
Flakebi
Flakebi approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(Just learned due to fat fingering: Ctrl+Shift+X changes text boxes between right-to-left and left-to-right 😄)

@mariusz-sikora-at-amd
Copy link
Contributor Author

I don't see the "Merge" button anywhere

@Flakebi Flakebi merged commit b249d1d into GPUOpen-Drivers:dev Apr 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flakebi Flakebi Flakebi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mariusz-sikora-at-amd @Flakebi