Skip to content

Fix warning about deprecated PtrType::get method. #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Fix warning about deprecated PtrType::get method. #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/ExampleMain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ void createFunctionExample(Module &module, const Twine &name) {

y6->setIndex(b.getInt32(1));

Value *p1 = b.create<xd::cpp::ReadOp>(b.getPtrTy(0));
Value *p1 = b.create<xd::cpp::ReadOp>(b.getPtrTy());
p1->setName("p1");
Value *p2 = b.create<xd::cpp::StreamAddOp>(p1, b.getInt64(14), b.getInt8(0));
p2->setName("p2");
Expand Down
2 changes: 1 addition & 1 deletion include/llvm-dialects/Dialect/Dialect.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def I64 : TgConstant<(IntegerType 64)>, Type;
def PointerType : BuiltinType {
let arguments = (args type:$self, AttrI32:$address_space);
// Supports both typed and opaque pointers.
let evaluate = "::llvm::PointerType::get(::llvm::Type::getInt8Ty($_context), $address_space)";
let evaluate = "::llvm::PointerType::get($_context, $address_space)";
let check = "$self->isPointerTy()";
let capture = ["$self->getPointerAddressSpace()"];
}
Expand Down
26 changes: 13 additions & 13 deletions test/example/generated/ExampleDialect.cpp.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,17 +564,17 @@ rhs
::llvm::Type * const retType = getRet()->getType();
(void)retType;

if (::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0) != lhsType) {
if (::llvm::PointerType::get(context, 0) != lhsType) {
errs << " unexpected value of $lhs:\n";
errs << " expected: " << printable(::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0)) << '\n';
errs << " expected: " << printable(::llvm::PointerType::get(context, 0)) << '\n';
errs << " actual: " << printable(lhsType) << '\n';

return false;
}

if (::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0) != rhsType) {
if (::llvm::PointerType::get(context, 0) != rhsType) {
errs << " unexpected value of $rhs:\n";
errs << " expected: " << printable(::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0)) << '\n';
errs << " expected: " << printable(::llvm::PointerType::get(context, 0)) << '\n';
errs << " actual: " << printable(rhsType) << '\n';

return false;
Expand Down Expand Up @@ -2077,9 +2077,9 @@ initial
::llvm::Type * const resultType = getResult()->getType();
(void)resultType;

if (::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0) != ptrType) {
if (::llvm::PointerType::get(context, 0) != ptrType) {
errs << " unexpected value of $ptr:\n";
errs << " expected: " << printable(::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0)) << '\n';
errs << " expected: " << printable(::llvm::PointerType::get(context, 0)) << '\n';
errs << " actual: " << printable(ptrType) << '\n';

return false;
Expand Down Expand Up @@ -2169,9 +2169,9 @@ initial
::llvm::Type * const resultType = getResult()->getType();
(void)resultType;

if (::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0) != ptrType) {
if (::llvm::PointerType::get(context, 0) != ptrType) {
errs << " unexpected value of $ptr:\n";
errs << " expected: " << printable(::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0)) << '\n';
errs << " expected: " << printable(::llvm::PointerType::get(context, 0)) << '\n';
errs << " actual: " << printable(ptrType) << '\n';

return false;
Expand Down Expand Up @@ -2261,9 +2261,9 @@ initial
::llvm::Type * const resultType = getResult()->getType();
(void)resultType;

if (::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0) != ptrType) {
if (::llvm::PointerType::get(context, 0) != ptrType) {
errs << " unexpected value of $ptr:\n";
errs << " expected: " << printable(::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0)) << '\n';
errs << " expected: " << printable(::llvm::PointerType::get(context, 0)) << '\n';
errs << " actual: " << printable(ptrType) << '\n';

return false;
Expand Down Expand Up @@ -2303,7 +2303,7 @@ initial
const ::llvm::AttributeList attrs
= ExampleDialect::get(context).getAttributeList(6);
auto fnType = ::llvm::FunctionType::get(::llvm::Type::getVoidTy(context), {
::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0),
::llvm::PointerType::get(context, 0),
}, false);

auto fn = module.getOrInsertFunction(s_name, fnType, attrs);
Expand Down Expand Up @@ -2343,10 +2343,10 @@ initial
return false;
}

if (getArgOperand(0)->getType() != ::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0)) {
if (getArgOperand(0)->getType() != ::llvm::PointerType::get(context, 0)) {
errs << " argument 0 (val) has type: "
<< *getArgOperand(0)->getType() << '\n';
errs << " expected: " << *::llvm::PointerType::get(::llvm::Type::getInt8Ty(context), 0) << '\n';
errs << " expected: " << *::llvm::PointerType::get(context, 0) << '\n';
return false;
}
::llvm::StringRef const val = getVal();
Expand Down