Skip to content

Conversation

@kolumb
Copy link

@kolumb kolumb commented Feb 8, 2021

  • Fixed error "runtime_error" is not a member of "std" by including <stdexcept>
  • Added build_msvc.bat that you can launch from simple cmd.exe. It can automatically enable MSVC console tools if needed and build the project.

@rys rys self-assigned this Feb 8, 2021
@rys
Copy link

rys commented Feb 8, 2021

Hi @kolumb, thanks for the PR! I think what's likely to happen is that I'll take b8ecbb4 to fix the error, but won't take the build fix because it would add something unique to HelloVulkan that we wouldn't add to other GPUOpen projects. HelloVulkan needs a little bit of a refresh, so I'll take a look at that as soon as I can, but it'll at least include the error fix.

I'll leave this PR open until that happens.

@Anteru
Copy link
Contributor

Anteru commented Feb 8, 2021

Thanks for taking care of this, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants