Added a simple compilation test and linux CI (and fix linux build) #446

Mrkol · 2024-08-28T23:31:26Z

Trivial compilation test is required because the sample is windows-specific. Linux CI is needed because pull requests must stop breaking linux builds. The tiny m_Handle(VMA_NULL) -> m_Handle() fix is needed to fix linux CI.

As promised @adam-sawicki-a . Same day delivery because my CI is still broken =)
(I will stop using master for my builds soon, I promise)

Compilation test is required because the smaple is windows-specific. Linux CI is needed because pull requests must stop breaking linux builds.

adam-sawicki-a · 2024-09-02T11:41:15Z

include/vk_mem_alloc.h

    return allocation->GetWin32Handle(allocator, hTargetProcess, pHandle);
 }
-#endif // VMA_EXTERNAL_MEMORY_WIN32 
+#endif // VMA_EXTERNAL_MEMORY_WIN32


It seems that you change many lines that are unrelated to your change due to using some automated formatting tools. Changes like this make it difficult to analyze the history of a file later (like "blame" function).

@Mrkol Let me know if you need help doing this :)

adam-sawicki-a · 2024-09-02T11:42:35Z

compilation_test/vma_impl.cpp

Would it be possible to reuse VulkanSample app for testing compilation on Linux instead of creating a new project? VulkanSample.cpp and VmaUsage.* files already have appropriate #ifdef-s and even some Clang-specific #pragma directives.

Does this mean we have to port VulkanSample app to Linux? I would be happy to help, but note that this would require glfw library most likely (#169).

IAmNotHanni · 2025-03-12T02:38:54Z

Does this pull request mean you want to move away from appveyor and use just GitHub actions instead? I could help with that. In my opinion, it would be nice to have a CI for Windows and Linux and both Debug and Release.

adam-sawicki-a · 2025-03-12T10:38:22Z

@IAmNotHanni Help is very welcome. It would be good to have CI builds set up for both Windows and Linux using some free online service. We had AppVeyor for Windows and TravisCI for Linux. Unfortunately, TravisCI stopped working >2 years ago. AppVeyor is still testing Windows.

It is enough to test if the library compiles successfully (both public interface and the code under VMA_IMPLEMENTATION).

Running some actual tests in CI could be considered in the future, but that would require access to some Vulkan implementation on the server (a GPU or software emulation) and likely major changes in the sample app and testing code, which I would prefer to avoid. The problem is I use Windows at work and I don't have a local Linux development environment to be able to test and fix things.

adam-sawicki-a · 2025-04-02T14:13:42Z

The proposed code fails with error:

Error: This request has been automatically failed because it uses a deprecated version of actions/cache: v2. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

IAmNotHanni · 2025-04-02T22:56:48Z

The proposed code fails with error:

Error: This request has been automatically failed because it uses a deprecated version of actions/cache: v2. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

Use actions/checkout@v4 like in here:

VulkanMemoryAllocator/.github/workflows/build.yml

Line 37 in d47cf43

uses: actions/checkout@v4

adam-sawicki-a · 2025-04-03T08:04:03Z

File ".github/workflows/linux.yaml" added by this change uses "actions/checkout@v4". I think it's the external repository "humbletim/[email protected]" referenced by this change that triggers this error. I think we should just download and install Vulkan SDK (or just its headers) without referencing such external repository.

IAmNotHanni · 2025-04-03T09:02:16Z

File ".github/workflows/linux.yaml" added by this change uses "actions/checkout@v4". I think it's the external repository "humbletim/[email protected]" referenced by this change that triggers this error. I think we should just download and install Vulkan SDK (or just its headers) without referencing such external repository.

Yes, it should be downloaded directly like this for example:

- name: Install Vulkan SDK
  shell: bash
  run: |
    curl -LS -o vulkansdk.tar.xz https://sdk.lunarg.com/sdk/download/${{ env.VMA_VULKAN_VERSION }}/linux/vulkansdk-linux-x86_64-${{ env.VMA_VULKAN_VERSION }}.tar.xz
    echo "${{ env.VMA_VULKAN_SDK_CHECKSUM_LINUX }} vulkansdk.tar.xz" | sha256sum --check
    mkdir -p ${{ env.VMA_VULKAN_SDK_PATH }}
    tar xf vulkansdk.tar.xz -C "${{ env.VMA_VULKAN_SDK_PATH }}"
    rm -rf vulkansdk.tar.xz

IAmNotHanni · 2025-04-03T15:51:03Z

@adam-sawicki-a Looking at the recent changes you pushed to master branch (0183545), one thing which points out to me is that clang and gcc seem to display no warnings at all in the CI build. In my experience, gcc and clang are much more detailed with warnings and they usually catch things which MSVC does not report by default. Maybe flags like -Wall and -Wextra are required to display any warnings?

adam-sawicki-a · 2025-04-03T15:53:05Z

Yes, this sounds like a good idea as long as those warnings don't fail the build. Can you please propose such change?

IAmNotHanni · 2025-04-03T15:53:35Z

Also, don't forget that in VmaSample code, there are a lot of #indef _WIN32, so on Linux, no code is realyl compiled from the tests. I guess the library itself is compiled though? I'm still working on #466 so we can have unit tests in the console on Linux :)

adam-sawicki-a · 2025-04-03T15:53:44Z

I added Linux CI build as #477, based on this ticket. Thank you very much for your help with it.

IAmNotHanni · 2025-04-03T15:53:48Z

Yes, this sounds like a good idea as long as those warnings don't fail the build. Can you please propose such change?

Yes, let me see..

adam-sawicki-a · 2025-04-03T15:58:38Z

Also, don't forget that in VmaSample code, there are a lot of #indef _WIN32, so on Linux, no code is realyl compiled from the tests. I guess the library itself is compiled though? I'm still working on #466 so we can have unit tests in the console on Linux :)

Yes, the library is compiled. I made a syntax error in "vk_mem_alloc.h" to check if the build fails - it does.

Added a simple compilation test and linux CI

86bacfd

Compilation test is required because the smaple is windows-specific. Linux CI is needed because pull requests must stop breaking linux builds.

adam-sawicki-a suggested changes Sep 2, 2024

View reviewed changes

IAmNotHanni mentioned this pull request Mar 13, 2025

Add Linux support for VulkanSample #466

Open

adam-sawicki-a added 2 commits April 2, 2025 14:14

Merge branch 'master' into Linux-CI-build

c5ac52b

Renamed build.yml to windows.yaml

6aa1d80

Some fixes in linux.yaml

d275cb1

adam-sawicki-a closed this Apr 3, 2025

Added a simple compilation test and linux CI (and fix linux build) #446

Added a simple compilation test and linux CI (and fix linux build) #446

Uh oh!

Conversation

Mrkol commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adam-sawicki-a Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

IAmNotHanni Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

adam-sawicki-a Sep 2, 2024

Choose a reason for hiding this comment

Uh oh!

IAmNotHanni Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IAmNotHanni commented Mar 12, 2025

Uh oh!

adam-sawicki-a commented Mar 12, 2025

Uh oh!

adam-sawicki-a commented Apr 2, 2025

Uh oh!

IAmNotHanni commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adam-sawicki-a commented Apr 3, 2025

Uh oh!

IAmNotHanni commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IAmNotHanni commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adam-sawicki-a commented Apr 3, 2025

Uh oh!

IAmNotHanni commented Apr 3, 2025

Uh oh!

adam-sawicki-a commented Apr 3, 2025

Uh oh!

IAmNotHanni commented Apr 3, 2025

Uh oh!

adam-sawicki-a commented Apr 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mrkol commented Aug 28, 2024 •

edited

Loading

IAmNotHanni Mar 12, 2025 •

edited

Loading

IAmNotHanni commented Apr 2, 2025 •

edited

Loading

IAmNotHanni commented Apr 3, 2025 •

edited

Loading

IAmNotHanni commented Apr 3, 2025 •

edited

Loading