-
Notifications
You must be signed in to change notification settings - Fork 0
develop -> main #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alta302
wants to merge
65
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
96ed632
a
Alta302 1dee711
Create : Project
Alta302 46c3892
Update : Files
jangseoyoung 37459a7
Update : VC
Alta302 2499427
Update : API
Alta302 9f157ef
Update : GRAMO
jangseoyoung 6ce3b4e
Update : Networking Functions
jangseoyoung 1509e20
Create : Auth
Alta302 d48f14c
Update : Calendar
Alta302 7a63afb
Update : API
Alta302 510eb00
Update : GRAMO
Alta302 3f4baa3
Update : Auth Profile
jangseoyoung 5c0866e
Update : Storyboard reference
jangseoyoung 688633b
Update : GRAMO
jangseoyoung db0e821
Update : GRAMO
Alta302 7186a87
Update : VC
jangseoyoung 54e7eac
Update : Storyboard
jangseoyoung 8f4309c
Update : GRAMO
jangseoyoung 5e4e245
Update : GRAMO
Alta302 bc585c8
Update : VC
jangseoyoung 02e2648
Update : Cell
jangseoyoung c108c04
Update : GRAMO
jangseoyoung fe473f0
Update : Model
jangseoyoung b4ff1b4
Update : storyboard
jangseoyoung 96f2a6a
Update : ViewController Extension
jangseoyoung 09b5882
Update : VC
jangseoyoung 015960c
Update : StoryBoard
jangseoyoung 9fa380c
Update : API
jangseoyoung 4080cc3
Update : GRAMO
jangseoyoung fda06a0
Auto stash before merge of "develop" and "origin/develop"
Alta302 cd27866
Delete : Files
Alta302 db22e94
Update : Calendar
Alta302 bbef632
Update : Auth
Alta302 dad6b76
Update : homework
Alta302 436e986
Update : Info
Alta302 53c149a
Update : Sidemenu
Alta302 2f1ae3b
Update : GRAMO
Alta302 efd3d4c
Update : Extension
jangseoyoung d4d7aff
Update : VC
jangseoyoung dd5dcd4
Update : GRAMO
jangseoyoung 893dfb6
Delete : Networking
jangseoyoung 1df41df
Update : VC
jangseoyoung 1537003
Update : GRAMO
jangseoyoung 270d382
Update : GRAMO
Alta302 a3e0f39
Update : final & private
Alta302 ce94173
Update : Asset & Launch
Alta302 6f49769
Update : GRAMO
Alta302 95b30f0
Update : Launch Screen
Alta302 5caa161
Update : GRAMO
Alta302 c91082f
Update : VC
jangseoyoung 7a4243c
Update : GRAMO
jangseoyoung 001d804
Update : Storyboard
jangseoyoung 04745de
Update : HTTPClient
jangseoyoung 63e8422
Update : GRAMO
Alta302 c8bbd35
Update : Firebase
jangseoyoung 54cd96f
Merge remote-tracking branch 'origin/develop' into develop
jangseoyoung b158d14
Update : UserInterfaceState
Alta302 9733b03
Merge remote-tracking branch 'origin/develop' into develop
Alta302 0965b70
Update : Auto Login
Alta302 dc407be
Auto stash before merge of "develop" and "origin/develop"
jangseoyoung ad09a8c
Update : Auto Login
Alta302 a8b8897
Merge remote-tracking branch 'origin/develop' into develop
Alta302 26c9e3a
Update : FCM
jangseoyoung d9c6714
Update : GRAMO
Alta302 d52cb6c
Update: 성과전시회
jangseoyoung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-10.3 KB
(93%)
GRAMO/GRAMO.xcworkspace/xcuserdata/jangseoyoung.xcuserdatad/UserInterfaceState.xcuserstate
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,15 +7,15 @@ | |
|
|
||
| import UIKit | ||
|
|
||
| class HomeworkAssignedViewController: UIViewController { | ||
| final class HomeworkAssignedViewController: UIViewController { | ||
|
|
||
| @IBOutlet weak var nameLabel: UILabel! | ||
| @IBOutlet weak var dateLabel: UILabel! | ||
| @IBOutlet weak var majorButton: UIButton! | ||
| @IBOutlet weak var selectDeadLineTextField: UITextField! | ||
| @IBOutlet weak var titleTextField: UITextField! | ||
| @IBOutlet weak var contentTextView: UITextView! | ||
| @IBOutlet weak var submitButton: UIButton! | ||
| @IBOutlet weak private var nameLabel: UILabel! | ||
| @IBOutlet weak private var dateLabel: UILabel! | ||
| @IBOutlet weak private var majorButton: UIButton! | ||
| @IBOutlet weak private var selectDeadLineTextField: UITextField! | ||
| @IBOutlet weak private var titleTextField: UITextField! | ||
| @IBOutlet weak private var contentTextView: UITextView! | ||
| @IBOutlet weak private var submitButton: UIButton! | ||
|
|
||
| var httpClient = HTTPClient() | ||
| var model : [HwContent] = [HwContent]() | ||
|
|
@@ -25,7 +25,6 @@ class HomeworkAssignedViewController: UIViewController { | |
| super.viewDidLoad() | ||
| setNavigationBar() | ||
| getContent(id: id) | ||
| // Do any additional setup after loading the view. | ||
| } | ||
|
|
||
| @IBAction func backButton1(_ sender: UIBarButtonItem){ | ||
|
|
@@ -42,32 +41,32 @@ class HomeworkAssignedViewController: UIViewController { | |
| } | ||
|
|
||
| func getContent(id: Int) { | ||
|
||
| httpClient.get(url: HomeworkAPI.getHomeworkContent(id).path(), params: nil, header: Header.token.header()).responseJSON {(res) in | ||
| httpClient.get(url: HomeworkAPI.getHomeworkContent(id).path(), params: nil, header: Header.token.header()).responseJSON { [self](res) in | ||
| switch res.response?.statusCode { | ||
| case 200 : | ||
| do{ | ||
| let data = res.data | ||
| let model = try JSONDecoder().decode(HwContent.self, from: data!) | ||
|
|
||
| self.selectDeadLineTextField.text = self.formatEndDate(model.endDate) | ||
| self.dateLabel.text = self.formatStartDate(model.startDate) | ||
| self.nameLabel.text = model.teacherName | ||
| self.majorButton.setTitle(self.setMajor(model.major), for: .normal) | ||
| self.titleTextField.text = model.title | ||
| self.contentTextView.text = model.description | ||
| selectDeadLineTextField.text = formatEndDate(model.endDate) | ||
| dateLabel.text = formatStartDate(model.startDate) | ||
| nameLabel.text = model.teacherName | ||
| majorButton.setTitle(setMajor(model.major), for: .normal) | ||
| titleTextField.text = model.title | ||
| contentTextView.text = model.description | ||
| } | ||
| catch{ | ||
| print("error: \(error)") | ||
| } | ||
|
|
||
| case 400 : print("400 - BAD REQUEST") | ||
| self.showAlert(title: "잘못된 요청입니다.") | ||
| self.showAlert(title: "잘못된 요청입니다.", message: nil) | ||
| case 401 : print("401 - Unauthorized") | ||
| self.showAlert(title: "허가되지 않았습니다.") | ||
| self.showAlert(title: "허가되지 않았습니다.", message: nil) | ||
| case 404 : print("404 - NOT FOUND") | ||
| self.showAlert(title: "오류가 발생했습니다.") | ||
| self.showAlert(title: "오류가 발생했습니다.", message: nil) | ||
| default : print(res.response?.statusCode ?? "default") | ||
| self.showAlert(title: "오류가 발생했습니다.") | ||
| self.showAlert(title: "오류가 발생했습니다.", message: nil) | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -79,26 +78,14 @@ class HomeworkAssignedViewController: UIViewController { | |
| case 201 : | ||
| self.navigationController?.popViewController(animated: true) | ||
| case 400 : print("400 - BAD REQUEST") | ||
| self.showAlert(title: "잘못된 요청입니다.") | ||
| self.showAlert(title: "잘못된 요청입니다.", message: nil) | ||
| case 401 : print("401 - Unauthorized") | ||
| self.showAlert(title: "허가되지 않았습니다.") | ||
| self.showAlert(title: "허가되지 않았습니다.", message: nil) | ||
| case 404 : print("404 - NOT FOUND") | ||
| self.showAlert(title: "오류가 발생했습니다.") | ||
| self.showAlert(title: "오류가 발생했습니다.", message: nil) | ||
| default : print(res.response?.statusCode ?? "default") | ||
| self.showAlert(title: "오류가 발생했습니다.") | ||
| self.showAlert(title: "오류가 발생했습니다.", message: nil) | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
| /* | ||
| // MARK: - Navigation | ||
|
|
||
| // In a storyboard-based application, you will often want to do a little preparation before navigation | ||
| override func prepare(for segue: UIStoryboardSegue, sender: Any?) { | ||
| // Get the new view controller using segue.destination. | ||
| // Pass the selected object to the new view controller. | ||
| } | ||
| */ | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
response 받을 때 self를 사용하지 않지 않으면 오류가 나서 안고친것같은데 오류나는게 당연한거에용 근데 이렇게 하면 강한참조순환이 올 수 있기 때문에 저번 코드리뷰에서 알려줬던 [unowned self]를 이용해서 self에 접근할 수 있어요 self를 쓰게되면 가독성이 떨어지기도 쉽습니다 ㅜ