Language settings autoupdate by tpolyakgs · Pull Request #63 · GRAPHISOFT/archicad-addon-cmake-tools

tpolyakgs · 2026-02-13T15:21:08Z

ACP-22926

As per request from AI solutions automatic update

Add an optional autoupdate flag to the Version resource on Windows, and to the Info.plist on macOS to enable easier, resource-based checking of an add-on’s update behavior. This optional flag should come from config.json, its value can be 0 or 1.
Support proper language subfolder creation in the pipeline, as currently it stores resources in ‘English’ subfolders, even in localized add-ons
Support proper Windows language and charset code in Version resource in localized add-ons.
Store GS Loc code in resource STRS 18000

Conditional Autoupdate flag in Version resource

LocalizationMappingTable.py in separate file

LocalizationMappingTable.py

BuildAddOn.py

…gTable

vhorvath-gs

Some minor tweaks.

vhorvath-gs · 2026-02-16T09:22:10Z

AddOn.rc.in

+	3 + 1,													/* VERSION_APPENDIX length */
+	0
+	"@addOnLanguage@" "\0"									/* Version appendix for localized data */


Suggested change

3 + 1, /* VERSION_APPENDIX length */

0

"@addOnLanguage@" "\0" /* Version appendix for localized data */

4,

0

"@addOnLanguage@\0"

Prefer 4 spaces to be in line with VersionInfo.rc.in.

That stray 0 looks odd. Doesn't look like anything in the documentation https://learn.microsoft.com/en-us/windows/win32/menurc/user-defined-resource

Prefer to do the length calculation for the string in CMake.

vhorvath-gs · 2026-02-16T09:26:42Z

CMakeCommon.cmake

        set (out "${CMAKE_CURRENT_BINARY_DIR}/${target}-VersionInfo.rc")
        configure_file ("${CMAKE_CURRENT_FUNCTION_LIST_DIR}/VersionInfo.rc.in" "${out}" @ONLY)
-        target_sources ("${target}" PRIVATE "${out}")
+
+        set (addOnRes "${CMAKE_CURRENT_BINARY_DIR}/${target}-AddOn.rc")
+        configure_file ("${CMAKE_CURRENT_FUNCTION_LIST_DIR}/AddOn.rc.in" "${addOnRes}" @ONLY)
+
+        target_sources ("${target}" PRIVATE "${out}" "${addOnRes}")


Turn this into a loop with foreach (res IN ITEMS VersionInfo AddOn).

vhorvath-gs · 2026-02-16T09:28:26Z

CMakeCommon.cmake

 endfunction ()

-function (generate_add_on_version_info outSemver)
+function (generate_add_on_version_info outSemver addOnLanguage)


Since the function is internal I almost feel like this parameter can be omitted, since it's present in the calling context anyway.

Either that or move it before the out parameter.

vhorvath-gs · 2026-02-16T09:29:44Z

CMakeCommon.cmake

        endif ()
    endif ()
-    generate_add_on_version_info (semver)
+    generate_add_on_version_info (semver ${addOnLanguage})


Prefer "${...}" for things you intend to pass as a single argument and where you don't want list expansion.

vhorvath-gs · 2026-02-16T09:32:43Z

CMakeCommon.cmake

-    # optional members (macOS code signing for start)
-    set (optionalMembers codesignIdentity developmentTeamId)
-    set (returnAs codesignIdentity developmentTeamId)
+    # optional members (macOS code signing for start, autoupdate next)


Please remove the comment here and below for the language list.

vhorvath-gs · 2026-02-16T09:38:09Z

BuildAddOn.py

+        winLangCharsetStr = '040904b0'
+        if languageCode != 'INT':
+            winLangCharsetStr = localizationMappingTable.get (languageCode, winLangCharsetStr)
+        projGenParams.append (f'-DAC_WIN_LANGCHARSET_STR={winLangCharsetStr}')


I know it comes from the header, but I don't like this *_STR/*Str suffix. Nothing else has this, so let's keep it that way.

vhorvath-gs · 2026-02-16T09:39:55Z

CMakeCommon.cmake

+        if (autoupdate STREQUAL "1")
+            set (autoupdate "\n\t\t\tVALUE \"Autoupdate\", \"1\"")
+        else ()
+            set (autoupdate "")
+        endif ()


Suggested change

if (autoupdate STREQUAL "1")

set (autoupdate "\n\t\t\tVALUE \"Autoupdate\", \"1\"")

else ()

set (autoupdate "")

endif ()

set (autoupdate "")

if (autoupdate STREQUAL "1")

set (autoupdate "\n\t\t\tVALUE \"Autoupdate\", \"1\"")

endif ()

In the other places as well.

vmihalyi-graphisoft · 2026-02-16T11:32:19Z

LocalizationMappingTable.py

+    with open(gsLocalizationPath, 'r', encoding='utf-8') as f:
+        gsLocalizationContent = f.read ()
+
+    if not pattern:


Few lines above you already assert that the pattern is not None.

vmihalyi-graphisoft · 2026-02-16T11:34:03Z

LocalizationMappingTable.py

+import re
+
+
+def FillLocalizationMappingTable (devKitPath) -> str:


This returns a dict[str, str], not a str. You can also type hint that the devKitPath is a Path (from pathlib).

asomorjai and others added 9 commits February 4, 2026 18:13

autoupdate flag added to plist handling on mac

d7a37e8

autoupdate flag added to VersionInfo.rc.in on Windows

be29fa1

Language code processing from GSLocalization.h

c840b7d

Window VersionInfo changes

f695a26

Pattern can be empty

1eb084e

Regex for WIN_LANGCHARSET_STR

75993c7

Conditional Autoupdate flag in Version resource

Add STRS 18000 automatically

7bf3523

Added language code on macOS to Info.plist

90868ce

Use correct character code in Version.info

8931e31

LocalizationMappingTable.py in separate file

tpolyakgs requested review from palenikm, vhorvath-gs and vmihalyi-graphisoft February 13, 2026 15:21

vmihalyi-graphisoft reviewed Feb 16, 2026

View reviewed changes

LocalizationMappingTable.py Outdated Show resolved Hide resolved

vmihalyi-graphisoft reviewed Feb 16, 2026

View reviewed changes

BuildAddOn.py Show resolved Hide resolved

Move GSLocalization.h parsing regex pattern to FillLocalizationMappin…

2798b44

…gTable

vhorvath-gs requested changes Feb 16, 2026

View reviewed changes

Comply with style guide

e45599d

vmihalyi-graphisoft reviewed Feb 16, 2026

View reviewed changes

Fixed hints

c9ea647

		import re


		def FillLocalizationMappingTable (devKitPath) -> str:

Conversation

tpolyakgs commented Feb 13, 2026

Uh oh!

Uh oh!

Uh oh!

vhorvath-gs left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants