feat(maps): set propertyNames for string map keys and support oneOf#495
Open
davidkna wants to merge 1 commit intoGREsau:masterfrom
Open
feat(maps): set propertyNames for string map keys and support oneOf#495davidkna wants to merge 1 commit intoGREsau:masterfrom
davidkna wants to merge 1 commit intoGREsau:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
propertyNamesfield for map schemas (similar to feat: add enum map key #384), but with validation logic to only add it for string-typed keys. This avoids validator confusion (as in the test suite) with non-string key types.oneOfin addition toanyOf(added via Added better map support #452) when analyzing map key schemas. This enables proper handling of enums with documentation comments, which generateoneOfschemas instead ofanyOf.