-
Notifications
You must be signed in to change notification settings - Fork 420
Portal #60 Add standalone Assurance Level Values page #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
_pages/assurance-levels.md
Outdated
| Authentication Assurance Level determines what second factors are allowed for user sign-in. | ||
| {{ aal_values }} | ||
|
|
||
| # Deprecated Service Values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[thought] hmm would it be possible to collapse these in an accordion? my preferences would be for them to be a little hidden (or only available on the oidc/saml specific views)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can collapse these, no problem.
I'm interested in discussing how this page should work: my initial thought was that this should go in the FAQ, but the ticket calls for a separate page. I'm also not too keen on this getting equal billing on the main nav.
At any rate, I'll wait for review from Nick before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it would be fine to be in the FAQ page, my desire for this (which was the impetus of the ticket) was to have a "neutral" place to link to rather than one that referenced a specific protocol
Sgtpluck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small thought, but otherwise looks good
|
ok, as discussed in coworking, I've moved the assurance levels info to the overview page ("Integration" in the nav, |
_pages/overview.md
Outdated
| href: "#user-flow" | ||
| - text: Service provider configuration | ||
| href: "#service-provider-configuration" | ||
| - text: Service Levels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other side nav titles are only 1st word capitalized thought out the dev docs. I'd like to keep that consistent so this should probably be changed. Authentication Assurance Levels should likely be changed too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update Service levels. AAL is a proper noun, so I think it should be capitalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, you were right, NIST uses lowercase for AAL
|
|
||
| Authentication Assurance Level determines what second factors are allowed for user sign-in. | ||
|
|
||
| {{ aal_values }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does {{ type_of_service }} exist in <div class="usa-prose" markdown="1"> but this doesn't? I think it should?
|
LGTM |
Relevant Ticket or Conversation:
Portal #60 Easier linking to IAL and AAL values
Description of Changes:
Creation of a new page for the Partnerships team to link to, describing IAL and AAL values (assurance level values). This uses the same partials as the OIDC and SAML authorization pages. This page also includes deprecated values as the protocol pages do.
There is no design or content guide for this page, so please give feedback on any text that is outside of the protocols partials, and on the name and placement of the nav link.
PR Checklist:
PR Review Standards: