Handle Raised Exception To Continue Sync#289
Merged
cmhedrickREI merged 7 commits intomainfrom May 29, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related to GSA/data.gov#4624
About
An analysis of the issue:
The old and current
rebuildcalls out to ourpackage_createwhich then calls out to a several other functions such asrollup_save_actionthen to ourtranslate_spatial. Within the translate spatial we then call thejson.dumpwhich we do wrap in an try/except, however this caused therebuildto fail in the update which then led to the rebuild raising the exception and then holding up the index. Switching out theraisefrom the original CKAN code we will instead log the package_ids of failing datasets while not holding up the entirerebuild.I also added a test case in which we take a bad json file that I think helps test bad json that indirectly helps support this change while not directly connected with the rebuild, it does help test for JSON failing json which could trigger the issue with old harvester.
downto spin down containers.versionwarningPR TASKS