change package name from - to _

[cmhedrickREI]

Pull Request

Related to GSA/data.gov#5268

About

Changes the - to _

PR TASKS

• The actual code changes.
• Tests written and passed.
• Any changes to docs?
• Bumped version number in setup.py (also checked on PyPi).

[neilmb]

Looks reasonable. Are we going to have to do this to every one of our ckanext repositories now?

[cmhedrickREI]

Looks reasonable. Are we going to have to do this to every one of our ckanext repositories now?

Thats a really good question... It seems like we may have to update most of our repos 🥲

[cmhedrickREI]

@neilmb apologies as I think I jumped and looked at the sketch to quickly. Tyler had noted a commit in the ticket that is actually a change to the deploy process. That change results in the replacement of the - with an _. I went off the sketch and was wrong. I updated the sketch to mimic the change noted in the commit. The updated code should be doing what is actually expected.

[cmhedrickREI]

(Screencap of the current geodata package showing the - and the datagovtheme showing the _ in the distribution names)

(Screencap of after following the new build process copied from the datagovtheme, resulting in the file with _)

[cmhedrickREI]

(Screencap of successful file name change on Pypi)