Refactor 'relation' definition in Relationship.json#57
Merged
jbrown-xentity merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
I agree with James's past work. Updated the 'relation' definition in Relationship.json to remove references to the 'Resource' class, which doesn't exist. It should accept strings that look like an identifier/IRI another asset/resource.
jbrown-xentity
approved these changes
Feb 27, 2026
Collaborator
jbrown-xentity
left a comment
jbrown-xentity
left a comment
There was a problem hiding this comment.
The only implementation of this class is in Dataset. So this should be defining another Dataset usually, or possibly another resource, but it shouldn't be inline. The reference should be to another ID, which should be a link or IRI.
Agreed and approve.
neilmb
approved these changes
Feb 27, 2026
Collaborator
neilmb
left a comment
neilmb
left a comment
There was a problem hiding this comment.
Agreed, this looks right to me.
jbrown-xentity
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I agree with James's past work. Updated the 'relation' definition in Relationship.json to remove references to the 'Resource' class, which doesn't exist. It should accept strings that look like an identifier/IRI for another asset/resource.
DOI DCAT-US 3.0 Documentation: Relationship - relation
Previous work: GSA/dcat-us3-tools@49d062b
Related to/addressing: #15