Update JSON schema per documentation for periodicity.#58
Draft
jbrown-xentity wants to merge 1 commit intomainfrom
Draft
Update JSON schema per documentation for periodicity.#58jbrown-xentity wants to merge 1 commit intomainfrom
jbrown-xentity wants to merge 1 commit intomainfrom
Conversation
Use defined frequency codes for different models/standards. Create "good" example, more work to be done for testing to work correctly (still bad reference links to be removed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plans to resolve #16, and address comments.
I agree @zopalmer14 , this shouldn't be any string. I've limited it to the lists from the different standards, and linked to the documentation in the JSON schema description. Because ISO-8601 is so open and contains so many possibilities, I decided to allow "recurring" type strings but to allow any number or value type without getting too in the weeds on what could possibly be implemented (months, days, time seconds, etc).
I think this should stay in draft until we can run a good and bad example through. I tried running the test, but because there are still too many bad references (and Dataset object references many/most of the various object types) the tests can't run on dataset. Need further changes before we revisit this.