refactor 'expectedDataType' definition in Metric.json#64
Merged
jbrown-xentity merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
Updated the 'expectedDataType' definition to remove references to 'anySimpleType' as it doesn't exist. The property description and examples in the documentation suggest a simple string should be sufficient.
jbrown-xentity
approved these changes
Mar 5, 2026
Collaborator
jbrown-xentity
left a comment
jbrown-xentity
left a comment
There was a problem hiding this comment.
Looks good from my end, well documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I agree with James's assessment. Updated the
expectedDataTypedefinition to remove references toanySimpleTypeas it doesn't exist. The property description and examples in the documentation suggest a simple string should be sufficient.DOI DCAT-US 3.0 Documentation: Metric - expectedDataType
'xsd:anySimpleType' Documentation: XML built-in datatypes, XML anySimpleType
Previous work: GSA/dcat-us3-tools@2a00049#diff-53ebd1692a2d4cfa5e4a21fd688a1e6846b4a546e02c47991bc42af76839d0d8
Should resolve: #21