Skip to content

refactor 'algorithm' definition in Checksum.json#65

Merged
jbrown-xentity merged 1 commit intomainfrom
bug/Checksum-algorithm-fix
Mar 10, 2026
Merged

refactor 'algorithm' definition in Checksum.json#65
jbrown-xentity merged 1 commit intomainfrom
bug/Checksum-algorithm-fix

Conversation

@zopalmer14
Copy link

Updated the algorithm definition to remove references to ChecksumAlgorithm as it doesn't exist. Instead, it expects a string (simple solution). Will add a subsequent comment to PR that explains a potential alternative solution.

DOI DCAT-US 3.0 Documentation: Checksum - algorithm

Previous work: GSA/dcat-us3-tools@2a00049#diff-53ebd1692a2d4cfa5e4a21fd688a1e6846b4a546e02c47991bc42af76839d0d8

Should resolve: #22

Updated the 'algorithm' definition to remove references to 'ChecksumAlgorithm' as it doesn't exist. Instead, it expects a string (simple solution). Will add a comment to PR that explains a potential alternative solution.
@zopalmer14
Copy link
Author

The aforementioned alternative solution (more complicated) that I propose for discussion is that the algorithm property instead checks for/expects a valid spdx:ChecksumAlgorithm value. To be more specific, it would validate that it receives an IRI that matches one of those within the 'has members' list, such as checksum algorithm sha256 (as seen in the DOI documentation example).

My worry with using this approach/solution is that it may be too prescriptive in that the list of checksum algorithms may not be exhaustive of all those used by agencies. Additionally, if there are new developments in the field, the list/controlled vocabulary may not be updated quickly enough to capture them.

Copy link
Collaborator

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@zopalmer14 zopalmer14 linked an issue Mar 6, 2026 that may be closed by this pull request
@jbrown-xentity jbrown-xentity merged commit 253fd65 into main Mar 10, 2026
1 check passed
@zopalmer14 zopalmer14 deleted the bug/Checksum-algorithm-fix branch March 13, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Checksum.algorithm

2 participants