Skip to content

refactor 'inDimension' definition in Metric.json#68

Merged
jbrown-xentity merged 2 commits intomainfrom
bug/Metric-inDimension-fix
Mar 10, 2026
Merged

refactor 'inDimension' definition in Metric.json#68
jbrown-xentity merged 2 commits intomainfrom
bug/Metric-inDimension-fix

Conversation

@zopalmer14
Copy link

Updated the inDimension definition to remove references to Dimension as it doesn't exist. The property description and examples in the documentation are a little vague but suggest that a string IRI should work for now.

Note: I will note my additional thoughts/caveats to the PR in a subsequent comment.

DOI DCAT-US 3.0 Documentation: Metric - inDimension

Previous work: GSA/dcat-us3-tools@cb4fb53

Should resolve: #23

Updated the 'inDimension' definition to remove references to 'Dimension' as it doesn't exist. The property description and examples in the documentation are a little vague but suggest that a string IRI should work for now.
@zopalmer14
Copy link
Author

Similar to my comment on James's PR for #20, I think there's an opportunity here to leverage the Concept class to address the issue of the missing/unimplemented Dimension (dqv:Dimension) class.

Based on the diagram of DCAT-US Supporting Classes, it appears that Dimension is a subclass of Concept, although the exact implementation of Dimension is not specified either in the diagram itself or the broader documentation, unlike for Role.

That being said, the example for Metric demonstrates that Dimension largely adheres to the Concept schema/definition with the exception of its inCategory property that seems to be an adaptation of Concept's inScheme property. This is further illustrated by the Data Quality Vocabulary (DQV) definition of Dimension that lists it as a subclass of Concept and notes that instances of the class may make use of the property dqv:inCategory.

Consequently, I think that one possible solution/approach would be to replace the invalid $ref to Dimension with one to Concept, although, considering the slight difference between the two, it would probably be better to implement a Dimension.json definition based on the Concept.json definition and the DQV documentation.

@zopalmer14 zopalmer14 linked an issue Mar 6, 2026 that may be closed by this pull request
@jbrown-xentity jbrown-xentity requested a review from a team March 10, 2026 16:27
Copy link
Collaborator

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me...

@jbrown-xentity jbrown-xentity merged commit d7b9200 into main Mar 10, 2026
1 check passed
@zopalmer14 zopalmer14 deleted the bug/Metric-inDimension-fix branch March 13, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Metric.inDimension

2 participants