Open
Conversation
In line with Neil and James's suggestions, updated the `Catalog` class to improve backwards compatibility with DCAT-US 1.1 and increase the versatility of the `keyword` property. Changes: - `keyword`: changed from a string to an array of strings; matches `Dataset` and aligns with the cardinality in the documentation - `description`, `publisher`, and `title`: removed from 'required' array; added option for a null value
zopalmer14
added
enhancement
jbrown-xentity
approved these changes
Mar 13, 2026
Collaborator
jbrown-xentity
left a comment
jbrown-xentity
left a comment
There was a problem hiding this comment.
This adds all the important things. One small quibble, but I would move this forward.
jsonschema/definitions/Catalog.json
Outdated
Comment on lines
458
to
470
| { | ||
| "oneOf": [ | ||
| { | ||
| "$ref": "#/definitions/Agent", | ||
| "description": "inline description of Agent" | ||
| }, | ||
| { | ||
| "type": "string", | ||
| "description": "reference iri of Agent", | ||
| "format": "iri" | ||
| } | ||
| ] | ||
| } |
Collaborator
There was a problem hiding this comment.
I would have flattened this, but it's technically correct and shouldn't hold up this improvement.
Author
There was a problem hiding this comment.
Good point. I added another commit to flatten it
Author
There was a problem hiding this comment.
Actually, I think title and description can be flattened as well. Will do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In line with Neil and James's suggestions, updated the
Catalogclass to improve the backwards compatibility with DCAT-US 1.1, and to increase the usability of thekeywordproperty and align with its use in theDatasetclass.Should resolve: #25, #74
Relevant Documentation: Catalog
Changes to Catalog.json:
keyword- changed from a string to an array of strings; matchesDatasetand aligns with the cardinality in the documentationdescription,publisher, andtitle- removed from 'required' array; added option for a null valueDiscussion Topics
identifier- Repeated point from myDocumentPR. Should it be changed from an array of strings to a string (e.g., from 0..n to 0..1)? We changed this forDatasetbut it has theotherIdentifierproperty andCatalogdoes not.Documentation and jsonschema Desynchronization
I don't think these are particularly important to fix, and I also know we've discussed ditching the HTML documentation and generating the documentation from the jsonschema, but I thought I would list what I noticed here anyways:
keyword- cardinality is 0..n in documentation, but 0..1 in jsonschema; fixed as described in changesrights- cardinality is 0..n in documentation, but 0..1 in jsonschemarightsHolder- cardinality is 0..n in property description and jsonschema, but 0..1 in class description