Open
Conversation
- `prefLabel`: removed from 'required' array and added an option for a null value; eases backwards compatibility and aligns with documentation
neilmb
approved these changes
Mar 13, 2026
Collaborator
neilmb
left a comment
neilmb
left a comment
There was a problem hiding this comment.
I like this improvement for backwards compatibility. Should we use the new "type": ["null", "string"] pattern for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In line with James's suggestion, updated the
Organizationclass to ease the backwards compatibility with DCAT-US 1.1Should resolve: #31
Relevant Documentation: Organization
Changes to Organization.json:
prefLabel- removed from 'required' array and added an option for a null value; eases backwards compatibility and aligns with the cardinality in the documentationDocumentation and jsonschema Desynchronization
I don't think these are particularly important to fix, and I also know we've discussed ditching the HTML documentation and generating the documentation from the jsonschema, but I thought I would list what I noticed here anyways:
prefLabel- cardinality is 0..1 in documentation, but 1 in jsonschema; fixed through above changesaltLabel- cardinality is 0..n on documentation, jsonschema is 0..1; does the language map change the cardinality?subOrganizationOf- cardinality is 0..n in property description and jsonschema, but 0..1 in class description