Open
Conversation
jbrown-xentity
approved these changes
Mar 12, 2026
Collaborator
There was a problem hiding this comment.
Ok, there are a lot of comments, but essentially this PR is trying to do 3 things:
- Flatten where possible (there are many locations of different possibilities of types for a field, and that optional list contains a single type of another possible list, which is redundant and silly).
- Update descriptions to be more declaritive and clear, reference the actual thing they are describing.
- Remove ID's and declare ID's at the class level, and update all references accordingly.
These are huge improvements, and current tests show that everything is passing!
My comments generally fall in 2 categories:
- Possible better/future cleanup
- 1 single error in the entire list.
I'm approving and giving my tentative backing to merge and start from this much better point!
zopalmer14
reviewed
Mar 13, 2026
zopalmer14
reviewed
Mar 13, 2026
zopalmer14
reviewed
Mar 13, 2026
zopalmer14
reviewed
Mar 13, 2026
zopalmer14
reviewed
Mar 13, 2026
zopalmer14
reviewed
Mar 13, 2026
zopalmer14
reviewed
Mar 13, 2026
zopalmer14
reviewed
Mar 13, 2026
zopalmer14
reviewed
Mar 13, 2026
zopalmer14
reviewed
Mar 13, 2026
Collaborator
Author
|
I think that I have addressed all of the feedback now. Thanks @zopalmer14 and @jbrown-xentity for your close reading! |
jbrown-xentity
approved these changes
Mar 13, 2026
Collaborator
jbrown-xentity
left a comment
There was a problem hiding this comment.
Still looks good.
Collaborator
Author
|
The Tiger Team is approving of this as code-cleanup and improvements in structure with no schema changes. |
zopalmer14
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large change that makes no changes to the DCAT schema, but it updates the version of the JSON Schema that we use so that we can properly connect our
Catalogschema to the sub-schemas using correct values for$id. We no longer need a top-leveldcat_us_3.0.0_schema.jsonfile that pulls in all of the sub-schemas and we delete an unuseddefinitions/Person.jsonthat never appears anywhere else. We also update thetest_json_schema.pyprogram to use the new setup.In the process we
$idfrom many, many places where it wasn't appropriatedescriptiontext for each schema and sub-schemaoneOfwithanyOfwhere appropriatedescriptionvalues throughout to make them more appropriate for use in a JSON Schema (i.e. removing "This property refers to ..." wherever it appears)descriptionvalues that havearrayvalues to specify that the property is a "List of ..."descriptionvaluesApologies to anyone who has to review all these changes, but hopefully they are very straightforward since they make the same type of changes over and over and over again.
Closes #73.