DIGITAL-693 updated drupal to 10.6 (first update s3fs then perform standard core update')

[arpage]

Jira ticket

DIGITAL-693

Purpose

@akf found that the current s3fs module version did not support Drupal core > 10.4, which was keeping the standard core update method from going past 10.4.9

This is the command she used: composer why-not drupal/core 10.6.2

The telling line in the output of that command was:

drupal/s3fs 3.7.0 requires drupal/core (^8.8 || ^9 || ~10.0.0 || ~10.1.0 || ~10.2.0 || ~10.3.0 || ~10.4.0 || ~11.0.0 || ~11.1.0)

Therefore I followed these steps, leading to a successful upgrade to 10.6.2 - using the standard core update method:

cd /srv
rm -rf digital-gov-drupal/
git clone git@github.com:GSA/digital-gov-drupal.git
cd digital-gov-drupal
composer install
./composer.sh require 'drupal/s3fs:^3.10'
./composer.sh update "drupal/core-*" --with-all-dependencies ### standard core update method
./robo.sh lando:init
lando si
lando drush status
Drupal version   : 10.6.2                            
Site URI         : http://digitalgov.lndo.site
...

Includes the following PRs that must be merged first

Deployment and testing

Local Setup

QA/Testing instructions

Checklist for the Developer

• A link to the JIRA ticket has been included above.
• No merge conflicts exist with the target branch.
• Automated tests have passed on this PR.
• A reviewer has been designated.
• Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

• The file changes are relevant to the task objective.
• Code is readable and includes appropriate commenting.
• Code standards and best practices are followed.
• QA/Test steps were successfully completed, if applicable.
• Applicable logs are free of errors.

[arpage]

From slack conversation w/ @akf

Amy Farrell (Digital Services, PDX)  [12:11 PM]
I think you should include the fix in the same PR. I'm seeing a couple of things there. This one might be important:

Error: Call to undefined method TwigCsFixer\Environment\StubbedEnvironment::getUnaryOperators()

And this seems weird ... why would a comment be forbidden?

FILE: ...igital-gov-drupal/web/modules/custom/convert_text/src/ShortcodeToEquiv.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 16 | ERROR | [x] Documentation comment contains forbidden comment "Provides
    |       |     methods to convert Hugo shortcodes to their Drupal
    |       |     equivalent..".
--------------------------------------------------------------------------------

[arpage]

I've fixed the errors noted above, and additionally:

1. updated Drush to 13, and
2. merged dev in, and successfully saw the node:24 container running, and
3. updated the composer robo packages (and dependencies) to get rid of some deprecation errors I was getting under php 8.4, and
4. github validations are still clean, and
5. static site generation seems to work well

[akf]

Looks good and I didn't see any error messages in the logs while I tested.

I'm puzzled as to why I'm not seeing something that looks like composer update drupal/core in the new lines in composer.log, but that's okay.