Skip to content

Autocomplete multiselect error message fix#277

Open
diego-ruiz-rei wants to merge 2 commits intomasterfrom
autocomplete-multiselect-wrapperfix
Open

Autocomplete multiselect error message fix#277
diego-ruiz-rei wants to merge 2 commits intomasterfrom
autocomplete-multiselect-wrapperfix

Conversation

@diego-ruiz-rei
Copy link
Contributor

@diego-ruiz-rei diego-ruiz-rei commented Feb 26, 2019

Description

If a form control with an error is passed in, ngOnInit would set the message in the label wrapper. However in autocomplete-multiselect.template.html, the errorMessage input value would override it. Pushing this.wrapper.formatErrors(this.control); into ngAfterViewInit so the above scenario is avoided.

Motivation and Context

Types of Changes

  • Bug fix (non-breaking change which fixes an issue) -> Apply bugfix label
  • New feature (non-breaking change which adds functionality) -> Apply enhancement label
  • Breaking change (fix or feature that would cause existing functionality to change) -> Apply breaking label

Screenshots (if appropriate):

Which browsers have you tested?

  • Internet Explorer 11
  • Edge
  • Chrome
  • Firefox
  • Safari

Checklist:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants