Autocomplete multiselect error message fix#277
Open
diego-ruiz-rei wants to merge 2 commits intomasterfrom
Open
Autocomplete multiselect error message fix#277diego-ruiz-rei wants to merge 2 commits intomasterfrom
diego-ruiz-rei wants to merge 2 commits intomasterfrom
Conversation
colinalford-gsa
approved these changes
Feb 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a form control with an error is passed in,
ngOnInitwould set the message in the label wrapper. However inautocomplete-multiselect.template.html, theerrorMessageinput value would override it. Pushingthis.wrapper.formatErrors(this.control);into ngAfterViewInit so the above scenario is avoided.Motivation and Context
Types of Changes
Screenshots (if appropriate):
Which browsers have you tested?
Checklist: