Added the option to set fsname manually#28
Open
lowBudgetHypothermia wants to merge 4 commits intoGSI-HPC:masterfrom
Open
Added the option to set fsname manually#28lowBudgetHypothermia wants to merge 4 commits intoGSI-HPC:masterfrom
lowBudgetHypothermia wants to merge 4 commits intoGSI-HPC:masterfrom
Conversation
This was done to allow the copytool to archive to the same fs (TSM) from different lustre instances.
ChristianTackeGSI
requested changes
Jan 6, 2026
| "\t\t""hostname of tsm server\n" | ||
| "\t-c, --conf <file>\n" | ||
| "\t\t""option conf file\n" | ||
| "\t-f, --fsname\n" |
Member
There was a problem hiding this comment.
Maybe add the argument? (like with the --conf above?
Suggested change
| "\t-f, --fsname\n" | |
| "\t-f, --fsname </override_fs_name>\n" |
Member
There was a problem hiding this comment.
Why not this one? Just being curious?
Collaborator
Author
|
The changes you requested were implemented. |
ChristianTackeGSI
requested changes
Jan 26, 2026
Member
ChristianTackeGSI
left a comment
ChristianTackeGSI
left a comment
There was a problem hiding this comment.
Please consider squashing all commits into one.
| "\t-c, --conf <file>\n" | ||
| "\t\t""option conf file\n" | ||
| "\t-f, --fsname\n" | ||
| "\t\t""set fsname manually </override_fs_name>\n" |
Member
There was a problem hiding this comment.
Added the </override_fs_name> to the wrong line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done to allow the copytool to archive to the same fs (TSM) from different lustre instances.