Skip to content

Editable dates 159#212

Open
calebkeener13 wants to merge 4 commits intomainfrom
editable-dates-159
Open

Editable dates 159#212
calebkeener13 wants to merge 4 commits intomainfrom
editable-dates-159

Conversation

@calebkeener13
Copy link
Contributor

  • Add disabled attribute to start date and end date inputs
  • Date inputs are now properly disabled when the date range checkbox is unchecked
  • Prevents users from editing dates when the date range option is not selected.

@netlify
Copy link

netlify bot commented Nov 17, 2025

Deploy Preview for bagel-rescue ready!

Name Link
🔨 Latest commit fadfbbd
🔍 Latest deploy log https://app.netlify.com/projects/bagel-rescue/deploys/691ba0f55cc1170008d6a149
😎 Deploy Preview https://deploy-preview-212--bagel-rescue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 17, 2025

Disclaimer: This comment was AI-generated and is not necessarily completely accurate. Please take code comments with a grain of salt.

Greptile Summary

  • Removed volunteer self-signup functionality including signup page, login page signup link, and middleware route
  • Modified sendVolunteerSignupEmails to remove signup link but function still creates unused database tokens
  • Contains dead code (validateSignUpToken, deleteSignUpToken) and logic error that creates tokens for non-existent signup flow

Confidence Score: 1/5

  • This PR has critical logic errors and should not be merged as-is
  • The PR creates a broken volunteer invitation flow - emails are sent but signup tokens are created for a deleted signup page, resulting in database clutter and confused users who receive invitations they cannot act on
  • Pay close attention to src/server/db/actions/email.ts - the email function still creates signup tokens even though signup page was deleted

Important Files Changed

Filename Overview
src/server/db/actions/email.ts Removed signup link from email but still creates unused tokens in database; contains dead code
src/app/signup/page.tsx Deleted entire signup page but backend still references signup flow

Sequence Diagram

sequenceDiagram
    participant Admin
    participant VolunteerAccountCreation
    participant sendVolunteerSignupEmails
    participant Database
    participant EmailService
    participant Volunteer
    
    Admin->>VolunteerAccountCreation: "Add volunteer emails"
    Admin->>VolunteerAccountCreation: "Click Invite Volunteers"
    VolunteerAccountCreation->>sendVolunteerSignupEmails: "Call with email list"
    loop "For each email"
        sendVolunteerSignupEmails->>Database: "Create signup token"
        sendVolunteerSignupEmails->>EmailService: "Send invitation email"
        EmailService->>Volunteer: "Email with instructions to contact admin"
    end
    sendVolunteerSignupEmails-->>VolunteerAccountCreation: "Return success"
    VolunteerAccountCreation->>Admin: "Show success alert"
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (2)

  1. src/server/db/actions/email.ts, line 117-120 (link)

    logic: still creates tokens in database even though signup page was deleted - these tokens will never be used and clutter the database

  2. src/server/db/actions/email.ts, line 160-189 (link)

    style: dead code - validateSignUpToken and deleteSignUpToken functions are no longer used since signup page was deleted

9 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

Comment on lines -142 to +143
<br/>
<a href="${signUpLink}" style="color: #1a73e8;">${signUpLink}</a>
<p>If you are having issues, copy and paste the link into your broswer.</p>
<p>Please contact your administrator for account setup instructions.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: typo: "be apart" should be "be a part" (apart means separated, a part means included)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant