Improved Bucket Drain Mechanics #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-works the bucket drain mechanics to match vanilla MC a little closer. Presently in FluidLogged if for example you try to empty a bucket and hit a stone block underneath a fence post, you can't empty the bucket. Whereas in normal fluid placing, hitting the block would place the fluid in the block above it(or to the side, etc).
This modifies the FluidLogged bucket draining mechanics to more accurately perform these checks, such that if for example you empty a bucket on solid block next to a fluidloggable block, then it will allow you to empty it and perform the fluidlogging.
There seems to still be a few issues with the bucket fill mechanics, but I haven't properly sorted that yet, so I will probably improve those similarly in another PR.