Open
Conversation
Collaborator
MathieuCarriere
commented
Feb 27, 2026
MathieuCarriere
commented
- Fixed typo "Scalling" ---> "Scaling"
- Made the approximation (kernel becomes zero after 2*sigma) controllable with extra (optional) parameter
- Fixed the Gaussian formula
mglisse
reviewed
Mar 11, 2026
| namespace Persistence_representations { | ||
|
|
||
| /** | ||
| * This is a simple procedure to create n by n (or 2*pixel_radius times 2*pixel_radius) cubical approximation of a |
Member
There was a problem hiding this comment.
The actual size seems to be 2 * pixel_radius + 1 squared.
Should we explain here what the new approximation means for the standard deviation of the Gaussian? It isn't obvious from the name.
| * @ingroup Persistence_representations | ||
| **/ | ||
| inline std::vector<std::vector<double> > create_Gaussian_filter(std::size_t pixel_radius, double sigma) | ||
| inline std::vector<std::vector<double> > create_Gaussian_filter(std::size_t pixel_radius, double approximation=2) |
Member
There was a problem hiding this comment.
We'll have to make sure to mention that in the release notes, old code will still compile but may silently change meaning, with an argument meant as sigma (and ignored) now interpreted as approximation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.