-
-
Notifications
You must be signed in to change notification settings - Fork 9
Used utility functions to move file functionality to file.py #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
GabeGiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good effort!
I added few comments and please follow the code style of the project for consistency, meaning capture_screenshot should be captureScreenshot
utils/file.py
Outdated
|
|
||
| import utils.logger as logger | ||
| from utils.logger import MessageTypes | ||
| from selenium.webdriver.remote.webdriver import WebDriver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check other files to see how the webdriver is imported
utils/file.py
Outdated
| logger.logDebugMessage("Error in writeResults", logger.MessageTypes.ERROR, e) | ||
|
|
||
|
|
||
| def createDirectory(path : str): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, introducing code style inconsistency with spacing. Check other functions around the code and you'll understand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing them out, really appreciate your review. I will make sure to not repeat these mistakes.
This PR introduces utility functions to improve code reuse and maintainability. The changes include:
🔹 Changes Made: