Add line range to input::SourceFile#311
Merged
GabrielDosReis merged 1 commit intomainfrom Jun 4, 2025
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| inline SourceFile::LineRange SourceFile::lines() const noexcept | ||
| { | ||
| return LineRange{*this}; |
Check warning
Code scanning / PREfast
The function is declared 'noexcept' but calls function 'LineRange()' which may throw exceptions (f.6). Warning
| throw FileMappingError{ path, GetLastError() }; | ||
| auto start = MapViewOfFile(mapping.get_handle(), FILE_MAP_READ, 0, 0, 0); | ||
| view = { reinterpret_cast<const std::byte*>(start), static_cast<View::size_type>(s.QuadPart) }; | ||
| view = { reinterpret_cast<const char8_t*>(start), static_cast<View::size_type>(s.QuadPart) }; |
Check warning
Code scanning / PREfast
Don't use reinterpret_cast. A cast from void* can use static_cast (type.1). Warning
| throw FileMappingError{ path, GetLastError() }; | ||
| auto start = MapViewOfFile(mapping.get_handle(), FILE_MAP_READ, 0, 0, 0); | ||
| view = { reinterpret_cast<const std::byte*>(start), static_cast<View::size_type>(s.QuadPart) }; | ||
| view = { reinterpret_cast<const char8_t*>(start), static_cast<View::size_type>(s.QuadPart) }; |
Check warning
Code scanning / PREfast
Don't use a static_cast for arithmetic conversions. Use brace initialization, gsl::narrow_cast or gsl::narrow (type.1). Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To iterate (one-pass) over physical lines from an input source file, assumed to have UTF-8 encoded contents.