CI: build before analysis to support C++ Modules#325
Merged
GabrielDosReis merged 1 commit intoGabrielDosReis:mainfrom Mar 17, 2026
Merged
CI: build before analysis to support C++ Modules#325GabrielDosReis merged 1 commit intoGabrielDosReis:mainfrom
GabrielDosReis merged 1 commit intoGabrielDosReis:mainfrom
Conversation
The code analysis action needs .ddi and .modmap files that CMake generates during the build phase (dependency scanning). Without a build step, the action cannot determine module dependencies or pass the correct -interface/-ifcOutput/-reference flags to cl.exe. Add a build step between configure and analysis.
GabrielDosReis
approved these changes
Mar 17, 2026
GabrielDosReis
added a commit
that referenced
this pull request
Mar 17, 2026
This reverts commit a45d0b8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Analysis CI job fails on projects using C++ Modules because the code analysis action needs
.ddiand.modmapfiles to determine module dependencies and pass the correct compiler flags (-interface,-ifcOutput,-reference). These files are generated by CMake during the build phase (Ninja's dependency scanning step), not during configuration.Without a build step, the action falls back to analyzing each source independently, which fails for module interface units and any source that imports a module.
Fix
Add a build step (
cmake --build build) between Configure and Run Analysis. The build produces:.ddifiles (P1689R5 dependency info) — used by the action to determine compilation order.modmapfiles — response files with-interface,-ifcOutput, and-referenceflags passed tocl.exeduring analysisRelated
.ddiand.modmapfiles