-
Notifications
You must be signed in to change notification settings - Fork 1
Update header #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update header #117
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8ceb86d
Update header keywords + file naming
aguinot 69c29dc
Merge remote-tracking branch 'origin/main' into update_header
aguinot ab487c3
Update image names
aguinot 50e3ca3
Add coment to saturation
aguinot b254a0c
Add ref for coadd ZP
aguinot b8e3b3a
Ref for the LSST zero points
aguinot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,12 +14,11 @@ modules: | |
| # the globals dict it uses when evaluating Eval items, so we can tell it to import it here. | ||
| - datetime | ||
|
|
||
| # Variables used to request LSST flux in the output catalog | ||
| # We evaluate the Euclid zeropoint here to save time in the output catalog. | ||
| eval_variables: | ||
| frubin_area: | ||
| feuclid_AB_ZP: | ||
| type : Eval | ||
| str : '3.14159 * (418**2 - 255**2)' | ||
| frubin_exptime: 30 | ||
| str : 'euclidlike.getBandpasses()["VIS"].zeropoint' | ||
|
|
||
| # Define some other information about the images | ||
| image: | ||
|
|
@@ -77,6 +76,10 @@ image: | |
| filter: { type: ObSeqData, field: filter } | ||
| exptime: { type: ObSeqData, field: exptime } | ||
|
|
||
| # This is not a required field for the processing but this is the easiest way to propagate | ||
| # this information to the output images. | ||
| obs_id: { type: ObSeqData, field: obs_id } | ||
|
|
||
| # Photon shooting is way faster for chromatic objects than fft, especially when most of them | ||
| # are fairly faint. The cross-over point for achromatic objects is generally of order | ||
| # flux=1.e6 or so (depending on the profile). Most of our objects here are much fainter than | ||
|
|
@@ -126,7 +129,7 @@ input: | |
| file_name: /path/to/skyCatalog.yaml | ||
| edge_pix: 512 | ||
| mjd: { type: ObSeqData, field: mjd } | ||
| exptime: { type: ObSeqData, field: exptime } | ||
| exptime: { type: ObSeqData, field: exptime } | ||
| obj_types: ['diffsky_galaxy','star','snana'] | ||
|
|
||
| output: | ||
|
|
@@ -135,51 +138,56 @@ output: | |
| dir: /path/to/output/images | ||
| file_name: | ||
| type: FormattedStr | ||
| format: "Euclidlike_WAS_truth_%s_%i_%i.fits.gz" | ||
| format: "EUC_ELSIM_SWL_DET-%s-%s-1-%s__%sZ.fits" | ||
| items: | ||
| - { type: ObSeqData, field: filter } | ||
| - { type: ObSeqData, field: visit } | ||
| - '@image.CCD' | ||
| - { type: Eval, iobsId: { type: ObSeqData, field: obs_id }, str: 'str(obsId).zfill(6)' } | ||
| - { type: Eval, idither: { type: ObSeqData, field: dither_id }, str: 'str(dither).zfill(2)' } | ||
| - { type: Eval, sccd: '@image.CCD', str: 'ccd.zfill(7)' } | ||
| - { type: Eval, sdate: { type: ObSeqData, field: date }, str: 'datetime.datetime.fromisoformat(date).strftime("%Y%m%dT%H%M%S.%f")' } | ||
|
|
||
| noise_image: | ||
| dir: /path/to/output/noise_images | ||
| file_name: | ||
| type: FormattedStr | ||
| format: "Euclidlike_WAS_truth_%s_%i_%i.noise.fits.gz" | ||
| format: "EUC_ELSIM_SWL_VAR-%s-%s-1-%s__%sZ.fits" | ||
| items: | ||
| - { type: ObSeqData, field: filter } | ||
| - { type: ObSeqData, field: visit } | ||
| - '@image.CCD' | ||
| - { type: Eval, iobsId: { type: ObSeqData, field: obs_id }, str: 'str(obsId).zfill(6)' } | ||
| - { type: Eval, idither: { type: ObSeqData, field: dither_id }, str: 'str(dither).zfill(2)' } | ||
| - { type: Eval, sccd: '@image.CCD', str: 'ccd.zfill(7)' } | ||
| - { type: Eval, sdate: { type: ObSeqData, field: date }, str: 'datetime.datetime.fromisoformat(date).strftime("%Y%m%dT%H%M%S.%f")' } | ||
|
|
||
| sky_image: | ||
| dir: /path/to/output/sky_images | ||
| file_name: | ||
| type: FormattedStr | ||
| format: "Euclidlike_WAS_truth_%s_%i_%i.sky.fits.gz" | ||
| format: "EUC_ELSIM_SWL_BKG-%s-%s-1-%s__%sZ.fits" | ||
| items: | ||
| - { type: ObSeqData, field: filter } | ||
| - { type: ObSeqData, field: visit } | ||
| - '@image.CCD' | ||
| - { type: Eval, iobsId: { type: ObSeqData, field: obs_id }, str: 'str(obsId).zfill(6)' } | ||
| - { type: Eval, idither: { type: ObSeqData, field: dither_id }, str: 'str(dither).zfill(2)' } | ||
| - { type: Eval, sccd: '@image.CCD', str: 'ccd.zfill(7)' } | ||
| - { type: Eval, sdate: { type: ObSeqData, field: date }, str: 'datetime.datetime.fromisoformat(date).strftime("%Y%m%dT%H%M%S.%f")' } | ||
|
|
||
| weight_image: | ||
| dir: /path/to/output/weight_images | ||
| file_name: | ||
| type: FormattedStr | ||
| format: "Euclidlike_WAS_truth_%s_%i_%i.weight.fits.gz" | ||
| format: "EUC_ELSIM_SWL_WGT-%s-%s-1-%s__%sZ.fits" | ||
| items: | ||
| - { type: ObSeqData, field: filter } | ||
| - { type: ObSeqData, field: visit } | ||
| - '@image.CCD' | ||
| - { type: Eval, iobsId: { type: ObSeqData, field: obs_id }, str: 'str(obsId).zfill(6)' } | ||
| - { type: Eval, idither: { type: ObSeqData, field: dither_id }, str: 'str(dither).zfill(2)' } | ||
| - { type: Eval, sccd: '@image.CCD', str: 'ccd.zfill(7)' } | ||
| - { type: Eval, sdate: { type: ObSeqData, field: date }, str: 'datetime.datetime.fromisoformat(date).strftime("%Y%m%dT%H%M%S.%f")' } | ||
|
|
||
| truth: | ||
| dir: /path/to/output/truth | ||
| file_name: | ||
| type: FormattedStr | ||
| format: "Euclidlike_WAS_index_%s_%i_%i.txt" | ||
| format: "EUC_ELSIM_SWL_WGT-%s-%s-1-%s__%sZ.txt" | ||
|
||
| items: | ||
| - { type: ObSeqData, field: filter } | ||
| - { type: ObSeqData, field: visit } | ||
| - '@image.CCD' | ||
| - { type: Eval, iobsId: { type: ObSeqData, field: obs_id }, str: 'str(obsId).zfill(6)' } | ||
| - { type: Eval, idither: { type: ObSeqData, field: dither_id }, str: 'str(dither).zfill(2)' } | ||
| - { type: Eval, sccd: '@image.CCD', str: 'ccd.zfill(7)' } | ||
| - { type: Eval, sdate: { type: ObSeqData, field: date }, str: 'datetime.datetime.fromisoformat(date).strftime("%Y%m%dT%H%M%S.%f")' } | ||
| columns: | ||
| object_id: "@object_id" | ||
| ra: "$sky_pos.ra.deg" | ||
|
|
@@ -189,15 +197,40 @@ output: | |
| realized_flux: "@realized_flux" | ||
| flux: "@flux" | ||
| mag: "@mag" | ||
| mag_AB: { type: Eval, str: '-2.5 * np.log10(@flux/@image.exptime/euclidlike.collecting_area) + euclid_AB_ZP' } | ||
| obj_type: "@object_type" | ||
| gal_disk_hlr: { type: SkyCatValue, field: diskHalfLightRadiusArcsec } | ||
| gal_redshift: { type: SkyCatValue, field: redshift } | ||
| gal_disk_hlr: { type: SkyCatValue, field: diskHalfLightRadiusArcsec } | ||
| gal_disk_e1: { type: SkyCatValue, field: diskEllipticity1 } | ||
| gal_disk_e2: { type: SkyCatValue, field: diskEllipticity2 } | ||
| gal_bulge_hlr: { type: SkyCatValue, field: spheroidHalfLightRadiusArcsec } | ||
| gal_bulge_e1: { type: SkyCatValue, field: spheroidEllipticity1 } | ||
| gal_bulge_e2: { type: SkyCatValue, field: spheroidEllipticity2 } | ||
| gal_shear1: { type: SkyCatValue, field: shear1 } | ||
| gal_shear2: { type: SkyCatValue, field: shear2 } | ||
| gal_convergence: { type: SkyCatValue, field: convergence } | ||
| sn_host_id: { type: SkyCatValue, field: host_id } | ||
| lsst_flux_r: | ||
| lsst_flux_u: { type: SkyCatValue, field: lsst_flux_u } | ||
| lsst_mag_u: | ||
| type : Eval | ||
| str : "-2.5 * np.log10(@output.truth.columns.lsst_flux_u) + 12.628" | ||
aguinot marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| lsst_flux_g: { type: SkyCatValue, field: lsst_flux_g } | ||
| lsst_mag_g: | ||
| type : Eval | ||
| fflux : { type: SkyCatValue, field: lsst_flux_r } | ||
| str : 'flux * rubin_exptime * rubin_area' | ||
| str : "-2.5 * np.log10(@output.truth.columns.lsst_flux_g) + 14.486" | ||
| lsst_flux_r: { type: SkyCatValue, field: lsst_flux_r } | ||
| lsst_mag_r: | ||
| type : Eval | ||
| fflux : { type: SkyCatValue, field: lsst_flux_r } | ||
| str : "-2.5 * np.log10(@output.truth.columns.lsst_flux_r) + 28.36" | ||
| str : "-2.5 * np.log10(@output.truth.columns.lsst_flux_r) + 14.325" | ||
| lsst_flux_i: { type: SkyCatValue, field: lsst_flux_i } | ||
| lsst_mag_i: | ||
| type : Eval | ||
| str : "-2.5 * np.log10(@output.truth.columns.lsst_flux_i) + 13.999" | ||
| lsst_flux_z: { type: SkyCatValue, field: lsst_flux_z } | ||
| lsst_mag_z: | ||
| type : Eval | ||
| str : "-2.5 * np.log10(@output.truth.columns.lsst_flux_z) + 13.613" | ||
| lsst_flux_y: { type: SkyCatValue, field: lsst_flux_y } | ||
| lsst_mag_y: | ||
| type : Eval | ||
| str : "-2.5 * np.log10(@output.truth.columns.lsst_flux_y) + 12.785" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ | |
| short_exptime_vis = 95 # s (for the shorter exposures with VIS taken in parallel with NISP imaging) | ||
| short_exptime_vis_eff = 89.52 # s (effective time VIS imaging exposures) (This is the one to use for flux computation) | ||
| read_noise = 4.4 # e-, https://www.euclid-ec.org/public/mission/vis/ | ||
| saturation = 200000 # e-, from https://www.euclid-ec.org/public/mission/vis/ | ||
| saturation = 65535 # ADU, https://arxiv.org/pdf/2503.15303 Sect. 3.3 (max for uint32) | ||
aguinot marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| n_dithers = 4 | ||
| n_ccd = 36 | ||
| n_ccd_row = 6 | ||
|
|
@@ -124,6 +124,9 @@ | |
| vis_blue_limit = 540 | ||
| vis_red_limit = 910 | ||
|
|
||
| # Coadd info | ||
| coadd_zeropoint = 23.9 # Euclid zero-point in AB mag, used in all bands | ||
|
||
|
|
||
| # Items to potentially do later; part of the galsim.roman setup that currently has no correspondence | ||
| # here. | ||
| # dark_current | ||
|
|
@@ -138,5 +141,4 @@ | |
| # separately, so there is no parameter for setting them (e.g. a Gaussian sigma) in | ||
| # this module. However, pointing errors / jitter are quantified in the VIS paper. | ||
| # | ||
| # The impact of the dichroic and of charge transfer inefficiency are not included. Same for | ||
| # saturation (200000 e-). | ||
| # The impact of the dichroic and of charge transfer inefficiency are not included. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one that we discussed renaming just now