Open
Conversation
Add the NISP information to euclidlike `instrument_params.py` file.
rmandelb
requested changes
Sep 11, 2024
Member
rmandelb
left a comment
rmandelb
left a comment
There was a problem hiding this comment.
I was a bit concerned about unit test coverage and docstrings - we can discuss if you want
|
|
||
| # Add some information related to NISP | ||
| nisp_gain = 2 # https://arxiv.org/pdf/2405.13496 Sect 4.3.7 | ||
| nisp_pixel_scale = 0.3 |
| @nb.njit | ||
| def circular_aper(N, r): | ||
| """ | ||
| Draws a circle of radius r in a square image of size N x N. |
| MAX_IMG_SIZE = 501 | ||
|
|
||
|
|
||
| def get_good_img_size(gmix, scale): |
Member
There was a problem hiding this comment.
It would be helpful for future developers if you could add docstrings for some of these functions, even just simple ones for those that are not user-facing
Member
|
Looks like there are open review comments and the branch is behind main. What is the plan for this one, @aguinot ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solve issue #69
Add photometry error as a possible output for all Euclid bands. It uses gaussian mixtures to approximate galaxy model (with ngmix). The PSF is modeled by a gaussian (not the best but not the worst.)
NOTE: merge after #72