Skip to content

Comments

Support parsing metadata fields added in LLVM 22#347

Draft
RyanGlScott wants to merge 5 commits intomasterfrom
rgs/llvm-22
Draft

Support parsing metadata fields added in LLVM 22#347
RyanGlScott wants to merge 5 commits intomasterfrom
rgs/llvm-22

Conversation

@RyanGlScott
Copy link
Contributor

This adds support for parsing the sourceLanguageVersion and dataSize fields, which were introduced in LLVM 22. As such, this fixes #339 and fixes #340, respectively.

This bumps the llvm-pretty submodule to bring in the corresponding changes from GaloisInc/llvm-pretty#189.


Marked as a draft pending GaloisInc/llvm-pretty#189 landing upstream.

@RyanGlScott
Copy link
Contributor Author

The Nix CI jobs are failing because they are trying to build llvm-pretty-bc-parser using GHC 9.14 for some reason, as can be seen in this failing CI log:

character-ps> Using ghc version 9.14.1 found on system at:
character-ps> /nix/store/vw7wss1jkcqk616mkqbqcdggczf28fbp-ghc-9.14.1/bin/ghc
character-ps> Using ghc-pkg version 9.14.1 found on system at:
character-ps> /nix/store/vw7wss1jkcqk616mkqbqcdggczf28fbp-ghc-9.14.1/bin/ghc-pkg-9.14.1
...

       > Configuring indexed-traversable-0.1.4...
       > Error: [Cabal-8010]
       > Encountered missing or private dependencies:
       >     base >=4.12 && <4.22 (installed: 4.22.0.0),
       >     containers >=0.6.0.1 && <0.8 (installed: 0.8)
       > CallStack (from HasCallStack):
       >   dieWithException, called at libraries/Cabal/Cabal/src/Distribution/Simple/Configure.hs:1620:11 in Cabal-3.16.0.0-7f1b:Distribution.Simple.Configure
       >
       For full logs, run:
         nix log /nix/store/s289gz63zkx0zwc0f8qvv9gq7lkpxb69-indexed-traversable-0.1.4.drv

Any idea how to make Nix not do that?

Copy link
Member

@kquick kquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, it uses the latest version of GHC available in the nixpkgs distribution. I pushed an update to the flake.nix to avoid use of GHC 9.14 for now. We can easily revert the change when GHC 9.14 changes are ready to go.

@RyanGlScott
Copy link
Contributor Author

Thanks, Kevin!

It's unfortunate that some of the llvm-quick-fuzz CI jobs appear to be flaking out. Perhaps we should more seriously consider removing these jobs, now that they're superseded by the Nix CI jobs (#330).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support DIBasicType's dataSize field (introduced in LLVM 22) Support DICompileUnit's sourceLanguageVersion field (introduced in LLVM 22)

3 participants