Draft
Conversation
RyanGlScott
reviewed
Oct 27, 2025
Comment on lines
+199
to
+205
| -> f (MT.BVType 32) -- r8 | ||
| -> f (MT.BVType 32) -- r9 | ||
| -> f (MT.BVType 32) -- r10 | ||
| -> f (MT.BVType 32) -- r11 | ||
| -> f (MT.BVType 32) -- r12 | ||
| -> f (MT.BVType 32) -- r13 (sp) | ||
| -> f (MT.BVType 32) -- r14 (lr) |
Contributor
There was a problem hiding this comment.
I think the comments above ARMSyscall could stand to be revised a little after these changes. Currently, they are:
macaw/macaw-aarch32/src/Data/Macaw/ARM/Arch.hs
Lines 174 to 189 in 54af25d
The "Arguments are passed in r0-r6, while the syscall number is in r7" bit should be updated to clarify that this specifically applies to the Linux ABI, but that other GPRs are also included such that this can also be used for different ABIs where other registers are involved.
61537b6 to
1e8442a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.