Conversation
This was referenced Feb 26, 2026
RyanGlScott
reviewed
Feb 26, 2026
This commit moves the allocate family of functions into core::crucible::alloc so that as_chunks_unchecked can call them.
RyanGlScott
added
the
standard libraries
RyanGlScott
approved these changes
Feb 27, 2026
Contributor
RyanGlScott
left a comment
RyanGlScott
left a comment
There was a problem hiding this comment.
Thanks! As a request, do you think that you could merge this after #247? It would be nice to include both PRs as part of your upcoming submodule bumps in GaloisInc/crucible#1756 and GaloisInc/saw-script#3075.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves the allocate family of functions into core::crucible::alloc so that as_chunks_unchecked can call them.