Replace lens with microlens{,-mtl,-th}#323
Draft
langston-barrett wants to merge 1 commit intomasterfrom
Draft
Conversation
The motivation is that `lens` has many, many (transitive) dependencies. This leads to: - Slow build times (the `microlens` README claims that it compiles in 3.5s whereas `lens` takes 4m10s) - Longer GHC upgrade latency (we have to wait until all of `lens`'s dependencies support a new GHC version) - Smaller GHC support windows (our GHC support window is limited by that of all of our transitive dependencies) - Supply chain risks such as lack of maintenance and even supply chain attacks (see recent NPM attacks)
9f037d4 to
3872921
Compare
Contributor
Author
|
Hmm, the build succeeds for me locally, and the error message barely mentions |
Contributor
|
That error message is confusing indeed. It turns out that this happens because one of the test suites depends on
To see this a bit more easily: |
Contributor
Author
|
Ah, well perhaps this would be fixed by the next release of parameterized-utils, which drops the dependency on microlens-pro then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation is that
lenshas many, many (transitive) dependencies. This leads to:microlensREADME claims that it compiles in 3.5s whereaslenstakes 4m10s)lens's dependencies support a new GHC version)This currently depends on GaloisInc/parameterized-utils#208, it should wait until that PR is merged and released.